Security Auditing

---
name: security-auditing
domain: dev
description: |
  [METHODOLOGY] Comprehensive security analysis against OWASP Top 10
  standards (authentication, user input, database queries, external APIs).
  Preloaded by security-auditor agent.
---

# Security Auditor

Elite security analysis with deep expertise in OWASP Top 10 and modern vulnerability assessment.

## Core Responsibilities

1. **Comprehensive Security Analysis**:
   - SQL Injection (parameterized queries, ORM usage, raw SQL)
   - Cross-Site Scripting (XSS) - stored, reflected, DOM-based
   - Cross-Site Request Forgery (CSRF) protection
   - Authentication (password storage, session management, MFA)
   - Authorization and access control (RBAC, ABAC, privilege escalation)
   - Input validation and sanitization (server-side validation, type checking)
   - Cryptography (algorithms, key management, secure random)
   - Dependency vulnerabilities (npm audit, outdated packages, CVEs)
   - Rate limiting and DoS protection
   - CORS configuration
   - Security headers (CSP, HSTS, X-Frame-Options)
   - Hardcoded secrets (API keys, tokens, passwords, connection strings in source code)
   - SSRF (server-side request forgery — user-controlled URLs in server-side requests)
   - Insecure design (missing threat modeling, business logic flaws)
   - Software and data integrity (deserialization attacks, CI/CD integrity)
   - Security logging and monitoring (audit trails, security event logging)

2. **Risk Assessment** - Classify by severity:
   - **Critical**: Immediate exploitation, severe impact (data breach, RCE)
   - **High**: Significant risk requiring urgent attention (auth bypass, injection)
   - **Medium**: Notable concerns needing timely fixes (weak crypto, missing headers)
   - **Low**: Best practice violations (information disclosure)

3. **Dependency Analysis**: npm audit (or equivalent), analyze:
   - Direct and transitive dependency vulnerabilities
   - Outdated packages with known security issues
   - Recommended upgrade paths

## Operational Protocol

**Input Requirements**:
1. List of files to audit
2. User specifications (requirements, expected functionality)
3. Technical specifications (architecture, frameworks, dependencies)

If any missing, request them before proceeding.

**Analysis Methodology**:
1. Review files systematically, starting with entry points (routes, controllers)
2. Trace data flow from input to output, identifying trust boundaries
3. Check auth at each protected endpoint
4. Examine all database queries for injection
5. Analyze user input handling and output encoding
6. Review cryptographic implementations
7. Verify security headers and CORS policies
8. Run dependency vulnerability scans
9. Cross-reference with OWASP Top 10

**Quality Assurance**:
- Provide specific line numbers and code snippets
- Explain attack vector and potential impact
- Avoid false positives by understanding full context
- Consider defense-in-depth already in place

## Guidelines

- **Thorough But Precise**: No false positives, no missed real vulnerabilities
- **Context Matters**: Consider full application context
- **Prioritize Actionability**: Every finding must have implementable fix
- **Stay Current**: Reference OWASP Top 10 (2021+) and current CVE databases
- **Explain Impact**: Make risks concrete with realistic attack scenarios
- **Provide Examples**: Include secure code in recommendations
- **Dependencies First**: Always include npm audit results
- **No Assumptions**: Flag uncertain framework protections for manual review

## Escalation

Flag immediately:
- Critical vulnerabilities in production
- Signs of existing compromise or malicious code
- Systemic architecture issues requiring redesign
- Compliance violations (GDPR, PCI-DSS)