Review Review

---
name: review-review
description: "Use when code changes need review before merge - validates architecture, types, security, and test coverage."
user-invocable: true
argument-hint: "[scope]"
allowed-tools: Read, Bash, Glob, Grep
---

Perform a full code review of changed files, validating against `docs/ARCHITECTURE.md`.

Scope: $ARGUMENTS (if empty, review files changed in git)

## Steps

1. Identify changed files:
```bash
git diff --name-only HEAD~1 2>/dev/null || git diff --name-only --cached 2>/dev/null || echo "Please specify the files"
```

2. Run automated checks:
```bash
npx tsc --noEmit
npx eslint --ext .ts,.tsx src/ app/ --max-warnings 0
npx vitest run --passWithNoTests
```

3. Check ARCHITECTURE.md patterns:
   - Services: no try/catch, no transformation
   - Adapters: pure functions
   - Hooks: use service+adapter, staleTime defined, `'use client'`
   - Stores: client state only (Zustand), selectors in consumers
   - Server Components: no hooks, no event handlers, no browser APIs
   - Client Components: `'use client'` directive, proper hook usage
   - Server Actions: `'use server'`, revalidatePath after mutations
   - Pages: metadata exported, loading.tsx + error.tsx siblings
   - error.tsx: must have `'use client'`
   - Naming: correct conventions
   - Boundaries: no cross-module imports

4. Classify:
   - VIOLATION -- ARCHITECTURE.md violation
   - ATTENTION -- Recommended improvement
   - COMPLIANT -- Correct
   - HIGHLIGHT -- Positive highlight

5. Produce report with verdict: Approved | With caveats | Requires changes